Android: enable chromium linker on the shells.

Android: enable chromium linker on the shells.

Chromium linker has been enabled for the full chrome,
and should also be exercised by content / chrome shells.

BUG=382485
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277892

[bulach, 2014-06-11 15:50:42]

ptal

[simonb1, 2014-06-11 16:11:29]

lgtm

Thanks for the change, lgtm.

Doesn't suppress the crazy linker in clang builds, so you will probably want to
wait for r276167 before committing.

https://src.chromium.org/viewvc/chrome?view=revision&revision=276167

[simonb (inactive), 2014-06-16 10:38:38]

Tricky bug, thanks for fixing.

https://codereview.chromium.org/329223002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/library_loader/Linker.java (right):

https://codereview.chromium.org/329223002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/Linker.java:478: Bundle
nullOrCopy = null;
Perhaps a more descriptive variable name?  clonedBundle?

https://codereview.chromium.org/329223002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/Linker.java:480: if
(DEBUG) Log.i(TAG, "useSharedRelros() being DE-SER");
Old debugging trace?  Message seems unhelpful without context.

https://codereview.chromium.org/329223002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/Linker.java:489: if
(DEBUG) Log.i(TAG, "useSharedRelros() called with " + nullOrCopy);
No longer strictly accurate.  Perhaps '... setting shared relros to " + ...'?

[bulach, 2014-06-16 21:54:55]

thanks simon! all comments addressed, another look please?

https://codereview.chromium.org/329223002/diff/40001/base/android/java/src/or...
File base/android/java/src/org/chromium/base/library_loader/Linker.java (right):

https://codereview.chromium.org/329223002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/Linker.java:478: Bundle
nullOrCopy = null;
On 2014/06/16 10:38:38, simonb wrote:
> Perhaps a more descriptive variable name?  clonedBundle?

Done.

https://codereview.chromium.org/329223002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/Linker.java:480: if
(DEBUG) Log.i(TAG, "useSharedRelros() being DE-SER");
On 2014/06/16 10:38:38, simonb wrote:
> Old debugging trace?  Message seems unhelpful without context.

ops, my bad. deleted.

https://codereview.chromium.org/329223002/diff/40001/base/android/java/src/or...
base/android/java/src/org/chromium/base/library_loader/Linker.java:489: if
(DEBUG) Log.i(TAG, "useSharedRelros() called with " + nullOrCopy);
On 2014/06/16 10:38:38, simonb wrote:
> No longer strictly accurate.  Perhaps '... setting shared relros to " + ...'?

Done.

[simonb1, 2014-06-16 23:02:53]

lgtm

Thanks.

[bulach, 2014-06-17 03:28:06]

+jam for content/content_shell.gypi OWNERS, thanks!

[jam, 2014-06-17 15:21:48]

lgtm

[bulach, 2014-06-17 16:07:53]

The CQ bit was checked by bulach@chromium.org

[commit-bot: I haz the power, 2014-06-17 16:08:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bulach@chromium.org/329223002/60001

[commit-bot: I haz the power, 2014-06-17 23:12:59]

Change committed as 277892