src/x87/full-codegen-x87.cc - Issue 379513002: X87: Fix computed properties on object literals with a double as propertyname.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/full-codegen-x87.cc

Issue 379513002: X87: Fix computed properties on object literals with a double as propertyname. (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x87/full-codegen-x87.cc

diff --git a/src/x87/full-codegen-x87.cc b/src/x87/full-codegen-x87.cc

index 0a0d96ec1bd96aba79c9209b0f714c2c5e332ad8..b132a757833944feb21ed79ad061bf0b03abc146 100644

--- a/src/x87/full-codegen-x87.cc

+++ b/src/x87/full-codegen-x87.cc

@@ -1643,8 +1643,8 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

VisitForStackValue(key);

VisitForStackValue(value);

if (property->emit_store()) {

- __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes

- __ CallRuntime(Runtime::kAddProperty, 4);

+ __ push(Immediate(Smi::FromInt(SLOPPY))); // Strict mode

+ __ CallRuntime(Runtime::kSetProperty, 4);

} else {

__ Drop(3);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »