Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 379513002: X87: Fix computed properties on object literals with a double as propertyname. (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1625 matching lines...) Expand 10 before | Expand all | Expand 10 after
1636 PrepareForBailoutForId(key->id(), NO_REGISTERS); 1636 PrepareForBailoutForId(key->id(), NO_REGISTERS);
1637 } else { 1637 } else {
1638 VisitForEffect(value); 1638 VisitForEffect(value);
1639 } 1639 }
1640 break; 1640 break;
1641 } 1641 }
1642 __ push(Operand(esp, 0)); // Duplicate receiver. 1642 __ push(Operand(esp, 0)); // Duplicate receiver.
1643 VisitForStackValue(key); 1643 VisitForStackValue(key);
1644 VisitForStackValue(value); 1644 VisitForStackValue(value);
1645 if (property->emit_store()) { 1645 if (property->emit_store()) {
1646 __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes 1646 __ push(Immediate(Smi::FromInt(SLOPPY))); // Strict mode
1647 __ CallRuntime(Runtime::kAddProperty, 4); 1647 __ CallRuntime(Runtime::kSetProperty, 4);
1648 } else { 1648 } else {
1649 __ Drop(3); 1649 __ Drop(3);
1650 } 1650 }
1651 break; 1651 break;
1652 case ObjectLiteral::Property::PROTOTYPE: 1652 case ObjectLiteral::Property::PROTOTYPE:
1653 __ push(Operand(esp, 0)); // Duplicate receiver. 1653 __ push(Operand(esp, 0)); // Duplicate receiver.
1654 VisitForStackValue(value); 1654 VisitForStackValue(value);
1655 if (property->emit_store()) { 1655 if (property->emit_store()) {
1656 __ CallRuntime(Runtime::kSetPrototype, 2); 1656 __ CallRuntime(Runtime::kSetPrototype, 2);
1657 } else { 1657 } else {
(...skipping 3137 matching lines...) Expand 10 before | Expand all | Expand 10 after
4795 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4795 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4796 Assembler::target_address_at(call_target_address, 4796 Assembler::target_address_at(call_target_address,
4797 unoptimized_code)); 4797 unoptimized_code));
4798 return OSR_AFTER_STACK_CHECK; 4798 return OSR_AFTER_STACK_CHECK;
4799 } 4799 }
4800 4800
4801 4801
4802 } } // namespace v8::internal 4802 } } // namespace v8::internal
4803 4803
4804 #endif // V8_TARGET_ARCH_X87 4804 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698