net/url_request/url_request_context_builder.cc - Issue 379293002: Add AssertNoURLRequests() to URLRequestContext subclass destructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_context_builder.cc

Issue 379293002: Add AssertNoURLRequests() to URLRequestContext subclass destructors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add to two omitted subclasses of subclasses of URLRequestContext. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_context_builder.cc

diff --git a/net/url_request/url_request_context_builder.cc b/net/url_request/url_request_context_builder.cc

index b58a0da1c26507b71dfc570593b95df61d6e087a..04351591c16a456cef2751f404f70aac1372db03 100644

--- a/net/url_request/url_request_context_builder.cc

+++ b/net/url_request/url_request_context_builder.cc

@@ -165,7 +165,9 @@ class BasicURLRequestContext : public URLRequestContext {

}

protected:

- virtual ~BasicURLRequestContext() {}

+ virtual ~BasicURLRequestContext() {

+ AssertNoURLRequests();

+ }

private:

// Threads should be torn down last.

« no previous file with comments | « net/url_request/url_request_context.h ('k') | net/url_request/url_request_test_util.cc » ('j') | no next file with comments »