net/url_request/url_request_context.h - Issue 379293002: Add AssertNoURLRequests() to URLRequestContext subclass destructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_context.h

Issue 379293002: Add AssertNoURLRequests() to URLRequestContext subclass destructors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add to two omitted subclasses of subclasses of URLRequestContext. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_context.h

diff --git a/net/url_request/url_request_context.h b/net/url_request/url_request_context.h

index 4242d72e6d9fed313c325313996f0deb1841d5e8..fe4213a437d85c28eda0037319a928bf5b9a0d41 100644

--- a/net/url_request/url_request_context.h

+++ b/net/url_request/url_request_context.h

@@ -199,6 +199,9 @@ class NET_EXPORT URLRequestContext

return url_requests_.get();

}

+ // CHECKs that no URLRequests using this context remain. Subclasses should

+ // additionally call AssertNoURLRequests() within their own destructor,

+ // prior to implicit destruction of subclass-owned state.

void AssertNoURLRequests() const;

// Get the underlying |HttpUserAgentSettings| implementation that provides

« no previous file with comments | « net/spdy/spdy_test_util_common.cc ('k') | net/url_request/url_request_context_builder.cc » ('j') | no next file with comments »