Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: Source/platform/graphics/ImageBufferSurface.h

Issue 379253002: Initial implementation of display list backed 2D canvases (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: use WebRuntimeFeatures Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/ImageBufferSurface.h
diff --git a/Source/platform/graphics/ImageBufferSurface.h b/Source/platform/graphics/ImageBufferSurface.h
index 58edfc546f24e437ef135265ad2e7567672ada0f..1eddd4571398f9486d8fdba6d3504eadd5bc647f 100644
--- a/Source/platform/graphics/ImageBufferSurface.h
+++ b/Source/platform/graphics/ImageBufferSurface.h
@@ -36,9 +36,11 @@
#include "platform/graphics/GraphicsTypes3D.h"
#include "wtf/FastAllocBase.h"
#include "wtf/Noncopyable.h"
+#include "wtf/PassRefPtr.h"
-class SkCanvas;
class SkBitmap;
+class SkCanvas;
+class SkPicture;
namespace blink { class WebLayer; }
@@ -54,10 +56,10 @@ enum OpacityMode {
class PLATFORM_EXPORT ImageBufferSurface {
WTF_MAKE_NONCOPYABLE(ImageBufferSurface); WTF_MAKE_FAST_ALLOCATED;
public:
- virtual ~ImageBufferSurface() { }
Sergey 2014/07/21 04:57:10 Is this just for the refactoring? The destructor i
Justin Novosad 2014/07/21 17:26:46 This happened for a similar reason. In an earlier
+ virtual ~ImageBufferSurface();
virtual SkCanvas* canvas() const = 0;
- virtual const SkBitmap& bitmap() const;
+ virtual const SkBitmap& bitmap();
virtual void willUse() { } // Called by ImageBuffer before reading or writing to the surface.
virtual void willReadback() { }
virtual bool isValid() const = 0;
@@ -71,6 +73,8 @@ public:
virtual void updateCachedBitmapIfNeeded() { }
virtual void setIsHidden(bool) { }
virtual void setImageBuffer(ImageBuffer*) { }
+ virtual PassRefPtr<SkPicture> getPicture();
+ virtual void didClearCanvas() { }
OpacityMode opacityMode() const { return m_opacityMode; }
const IntSize& size() const { return m_size; }

Powered by Google App Engine
This is Rietveld 408576698