Initial implementation of display list backed 2D canvases

Source/platform/graphics/ImageBufferSurface.h

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #ifndef ImageBufferSurface_h
 #define ImageBufferSurface_h
 
 #include "platform/PlatformExport.h"
 #include "platform/geometry/IntSize.h"
 #include "platform/graphics/GraphicsTypes3D.h"
 #include "wtf/FastAllocBase.h"
 #include "wtf/Noncopyable.h"
+#include "wtf/PassRefPtr.h"
 
+class SkBitmap;
 class SkCanvas;
-class SkBitmap;
+class SkPicture;
 
 namespace blink { class WebLayer; }
 
 namespace WebCore {
 
 class ImageBuffer;
 
 enum OpacityMode {
     NonOpaque,
     Opaque,
 };
 
 class PLATFORM_EXPORT ImageBufferSurface {
     WTF_MAKE_NONCOPYABLE(ImageBufferSurface); WTF_MAKE_FAST_ALLOCATED;
 public:
-    virtual ~ImageBufferSurface() { }

[Sergey, 2014/07/21 04:57:10]

Is this just for the refactoring? The destructor is still empty, so I wonder, if
this change is actually necessary.

[Justin Novosad, 2014/07/21 17:26:46]

This happened for a similar reason. In an earlier version of this patch, the
destructor was de-referencing ref counted pointers, which forced me to move it
to the .cpp.  This is no longer the case, so I can put it back how it was. 
Thanks.

+    virtual ~ImageBufferSurface();
 
     virtual SkCanvas* canvas() const = 0;
-    virtual const SkBitmap& bitmap() const;
+    virtual const SkBitmap& bitmap();
     virtual void willUse() { } // Called by ImageBuffer before reading or writing to the surface.
     virtual void willReadback() { }
     virtual bool isValid() const = 0;
     virtual bool restore() { return false; };
     virtual blink::WebLayer* layer() const { return 0; };
     virtual bool isAccelerated() const { return false; }
     virtual Platform3DObject getBackingTexture() const { return 0; }
     virtual bool cachedBitmapEnabled() const { return false; }
     virtual const SkBitmap& cachedBitmap() const;
     virtual void invalidateCachedBitmap() { }
     virtual void updateCachedBitmapIfNeeded() { }
     virtual void setIsHidden(bool) { }
     virtual void setImageBuffer(ImageBuffer*) { }
+    virtual PassRefPtr<SkPicture> getPicture();
+    virtual void didClearCanvas() { }
 
     OpacityMode opacityMode() const { return m_opacityMode; }
     const IntSize& size() const { return m_size; }
     void notifyIsValidChanged(bool isValid) const;
 
 protected:
     ImageBufferSurface(const IntSize&, OpacityMode);
     void clear();
 
 private:
     OpacityMode m_opacityMode;
     IntSize m_size;
 };
 
 } // namespace WebCore
 
 #endif