Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 379153002: Revert 281905 "Revert of NaCl: Update revision in DEPS, r13441 -..." (Closed)

Created:
6 years, 5 months ago by kaliamoorthi
Modified:
6 years, 5 months ago
Reviewers:
samuong
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 281905 "Revert of NaCl: Update revision in DEPS, r13441 -..." > Revert of NaCl: Update revision in DEPS, r13441 -> r13452 (https://codereview.chromium.org/371413003/) > > Reason for revert: > Suspect this is causing PPAPINaClNewlibTest.FileIO to crash on Mac: > > http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%283%29/builds/3112 > > Original issue's description: > > NaCl: Update revision in DEPS, r13441 -> r13452 > > > > This pulls in the following Native Client changes: > > > > r13442: (dyen) Added support for log uploading for commands in toolchain_build. > > r13443: (noelallen) Rolls DEPS file to get deps aware toolchains. > > r13445: (dyen) Added a log_url field to package archs and recalculated revision hashes. > > r13446: (ncbray) Factor arg parsing in sel_ldr into its own function. > > r13447: (ncbray) Add my chromium account to OWNERS with my google account. > > r13448: (dyen) Fixed repo_tools invalid reference to pynacl. > > r13449: (thakis) Undo cros-specific hack now that r13435 seems to have stuck. > > r13450: (ncbray) Consolidate sel_ldr's configuration logic. > > r13451: (dyen) Package Version script now supports downloading build logs. > > r13452: (hamaji) Non-SFI Mode: Add isatty interface > > > > BUG=none > > TEST=browser_tests and nacl_integration > > CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281849 > > TBR=bradnelson@google.com,ncbray@chromium.org,mseaborn@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=none > > Review URL: https://codereview.chromium.org/379663002 Reverting this causes new failure. Hence reverting the revert. TBR=samuong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kaliamoorthi
6 years, 5 months ago (2014-07-09 12:36:51 UTC) #1
kaliamoorthi
Committed patchset #1 manually as r282009 (tree was closed).
6 years, 5 months ago (2014-07-09 12:36:56 UTC) #2
samuong
6 years, 5 months ago (2014-07-09 12:42:53 UTC) #3
Message was sent while issue was closed.
On 2014/07/09 12:36:56, kaliamoorthi wrote:
> Committed patchset #1 manually as r282009 (tree was closed).

LGTM. I believe r281879 fixes the crash that I was seeing anyway, so reverting
my revert shouldn't cause you any new problems.

Powered by Google App Engine
This is Rietveld 408576698