Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 379663002: Revert of NaCl: Update revision in DEPS, r13441 -> r13452 (Closed)

Created:
6 years, 5 months ago by samuong
Modified:
6 years, 5 months ago
CC:
chromium-reviews, David Yen, hamaji, native-client-reviews_googlegroups.com, Nick Bray (chromium), noelallen_use_chromium, Nico
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, r13441 -> r13452 (https://codereview.chromium.org/371413003/) Reason for revert: Suspect this is causing PPAPINaClNewlibTest.FileIO to crash on Mac: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%20Tests%20%283%29/builds/3112 Original issue's description: > NaCl: Update revision in DEPS, r13441 -> r13452 > > This pulls in the following Native Client changes: > > r13442: (dyen) Added support for log uploading for commands in toolchain_build. > r13443: (noelallen) Rolls DEPS file to get deps aware toolchains. > r13445: (dyen) Added a log_url field to package archs and recalculated revision hashes. > r13446: (ncbray) Factor arg parsing in sel_ldr into its own function. > r13447: (ncbray) Add my chromium account to OWNERS with my google account. > r13448: (dyen) Fixed repo_tools invalid reference to pynacl. > r13449: (thakis) Undo cros-specific hack now that r13435 seems to have stuck. > r13450: (ncbray) Consolidate sel_ldr's configuration logic. > r13451: (dyen) Package Version script now supports downloading build logs. > r13452: (hamaji) Non-SFI Mode: Add isatty interface > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281849 TBR=bradnelson@google.com,ncbray@chromium.org,mseaborn@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
samuong
Created Revert of NaCl: Update revision in DEPS, r13441 -> r13452
6 years, 5 months ago (2014-07-09 00:34:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/379663002/1
6 years, 5 months ago (2014-07-09 00:35:19 UTC) #2
commit-bot: I haz the power
Change committed as 281905
6 years, 5 months ago (2014-07-09 00:37:20 UTC) #3
Mark Seaborn
On 8 July 2014 17:34, <samuong@chromium.org> wrote: > Reviewers: bradn, Nick Bray (chromium), Mark Seaborn, ...
6 years, 5 months ago (2014-07-10 17:40:57 UTC) #4
Mark Seaborn
6 years, 5 months ago (2014-07-10 17:40:57 UTC) #5 
On 8 July 2014 17:34, <samuong@chromium.org> wrote:

> Reviewers: bradn, Nick Bray (chromium), Mark Seaborn,
>
> Message:
> Created Revert of NaCl: Update revision in DEPS, r13441 -> r13452
>
> Description:
> Revert of NaCl: Update revision in DEPS, r13441 -> r13452
> (https://codereview.chromium.org/371413003/)
>
> Reason for revert:
> Suspect this is causing PPAPINaClNewlibTest.FileIO to crash on Mac:
>
> http://build.chromium.org/p/chromium.memory/builders/Mac%
> 20ASan%20Tests%20%283%29/builds/3112


Please copy the failure message in cases like this, because Buildbot URLs
expire quite quickly.

In this case, the failure was:

PPAPINaClNewlibTest.FileIO (run #1):
[ RUN      ] PPAPINaClNewlibTest.FileIO
HTTP server started on http://127.0.0.1:51604...
sending server_data: {"host": "127.0.0.1", "port": 51604} (36 bytes)
[9013,2963992576:17:09:08.946349] Native Client module will be loaded at
base address 0x0000000040000000
[9004:3847:0708/170909:INFO:CONSOLE(177)] "OpenForceAsync finished in 0.184
seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "Open finished in 0.134
seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "OpenBlocking finished in 0.135
seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "OpenBackground finished in 0.128
seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "OpenDirectoryForceAsync finished
in 0.018 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "OpenDirectory finished in 0.006
seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "OpenDirectoryBlocking finished
in 0.017 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "OpenDirectoryBackground finished
in 0.014 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:82179:0708/170909:ERROR:quota_reservation_buffer.cc(51)] Detected
over consumption of the storage quota beyond its reservation
[9004:3847:0708/170909:INFO:CONSOLE(177)] "ReadWriteSetLengthForceAsync
finished in 0.021 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:22275:0708/170909:ERROR:quota_reservation_buffer.cc(51)] Detected
over consumption of the storage quota beyond its reservation
[9004:3847:0708/170909:INFO:CONSOLE(177)] "ReadWriteSetLength finished in
0.028 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:82179:0708/170909:ERROR:quota_reservation_buffer.cc(51)] Detected
over consumption of the storage quota beyond its reservation
[9004:3847:0708/170909:INFO:CONSOLE(177)] "ReadWriteSetLengthBlocking
finished in 0.033 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:82179:0708/170909:ERROR:quota_reservation_buffer.cc(51)] Detected
over consumption of the storage quota beyond its reservation
[9004:3847:0708/170909:INFO:CONSOLE(177)] "ReadWriteSetLengthBackground
finished in 0.019 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)]
"ReadToArrayWriteSetLengthForceAsync finished in 0.018 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "ReadToArrayWriteSetLength
finished in 0.015 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)]
"ReadToArrayWriteSetLengthBlocking finished in 0.000 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)]
"ReadToArrayWriteSetLengthBackground finished in 0.000 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "TouchQueryForceAsync finished in
0.031 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "TouchQuery finished in 0.016
seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "TouchQueryBlocking finished in
0.032 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170909:INFO:CONSOLE(177)] "TouchQueryBackground finished in
0.017 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
[9004:3847:0708/170910:INFO:CONSOLE(177)] "AbortCallsForceAsync finished in
0.088 seconds.", source:
http://127.0.0.1:51604/files/test_case.html?mode=nacl_newlib&testcase=FileIO_...,
(177)
=================================================================
==9013==ERROR: AddressSanitizer: heap-use-after-free on address 0x168239f0
at pc 0xf56868e bp 0xb0b86cd8 sp 0xb0b86cd4
READ of size 8 at 0x168239f0 thread T20
    #0 0xf56868d
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xf07f68d)
    #1 0xdcfcd32
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd813d32)
    #2 0xdcb9310
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd7d0310)
    #3 0xdc85c8e
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd79cc8e)
    #4 0xdc994f7
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd7b04f7)
    #5 0xdd1ced7
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd833ed7)

0x168239f0 is located 48 bytes inside of 56-byte region
[0x168239c0,0x168239f8)
freed by thread T14 here:
    #0 0x341fb
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Helper NP.app/Contents/MacOS/libclang_rt.asan_osx_dynamic.dylib+0x301fb)
    #1 0xbb6dbfc
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xb684bfc)
    #2 0xf565947
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xf07c947)
    #3 0xf5651fa
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xf07c1fa)
    #4 0xf5687a7
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xf07f7a7)
    #5 0xdcf84f3
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd80f4f3)
    #6 0xdcb3245
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd7ca245)
    #7 0xdc8635a
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd79d35a)
    #8 0xdc994f7
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd7b04f7)
    #9 0xdd1ced7
(/Volumes/data/b/build/slave/Mac_ASan_Tests__3_/build/src/out/Release/Chromium.app/Contents/Versions/38.0.2085.0/Chromium
Framework.framework/Chromium Framework+0xd833ed7)


Not very useful in the absence of symbols, unfortunately. :-(

ncbray pointed out to me that the Mac ASan tests went green again in
subsequent builds before this revert was committed, so I don't think the
DEPS roll was the cause of the problem.

Cheers,
Mark

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698