Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 378873002: Move permission check from GuestViewInternal to derived GuestView (Closed)

Created:
6 years, 5 months ago by Fady Samuel
Modified:
6 years, 5 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@app_view_meat
Project:
chromium
Visibility:
Public.

Description

Move permission check from GuestViewInternal to derived GuestView BUG=364141 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282766

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Diff against tip of tree #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -15 lines) Patch
M chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/guest_view/app_view/app_view_guest.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/app_view/app_view_guest.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/guest_view_base.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Fady Samuel
6 years, 5 months ago (2014-07-08 17:01:38 UTC) #1
lazyboy
lgtm
6 years, 5 months ago (2014-07-08 18:28:04 UTC) #2
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 5 months ago (2014-07-11 19:54:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/378873002/40001
6 years, 5 months ago (2014-07-11 19:55:35 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 01:10:15 UTC) #5
Message was sent while issue was closed.
Change committed as 282766

Powered by Google App Engine
This is Rietveld 408576698