Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: chrome/browser/guest_view/app_view/app_view_guest.cc

Issue 378873002: Move permission check from GuestViewInternal to derived GuestView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app_view_meat
Patch Set: Diff against tip of tree Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/guest_view/app_view/app_view_guest.h" 5 #include "chrome/browser/guest_view/app_view/app_view_guest.h"
6 6
7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" 7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/guest_view/app_view/app_view_constants.h" 9 #include "chrome/browser/guest_view/app_view/app_view_constants.h"
10 #include "chrome/browser/guest_view/guest_view_manager.h" 10 #include "chrome/browser/guest_view/guest_view_manager.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/renderer_context_menu/context_menu_delegate.h" 12 #include "chrome/browser/renderer_context_menu/context_menu_delegate.h"
13 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h" 13 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
14 #include "content/public/browser/render_view_host.h" 14 #include "content/public/browser/render_view_host.h"
15 #include "content/public/common/renderer_preferences.h" 15 #include "content/public/common/renderer_preferences.h"
16 #include "extensions/browser/api/app_runtime/app_runtime_api.h" 16 #include "extensions/browser/api/app_runtime/app_runtime_api.h"
17 #include "extensions/browser/event_router.h" 17 #include "extensions/browser/event_router.h"
18 #include "extensions/browser/extension_host.h" 18 #include "extensions/browser/extension_host.h"
19 #include "extensions/browser/extension_system.h" 19 #include "extensions/browser/extension_system.h"
20 #include "extensions/browser/lazy_background_task_queue.h" 20 #include "extensions/browser/lazy_background_task_queue.h"
21 #include "extensions/browser/view_type_utils.h" 21 #include "extensions/browser/view_type_utils.h"
22 #include "extensions/common/api/app_runtime.h" 22 #include "extensions/common/api/app_runtime.h"
23 #include "extensions/common/extension_messages.h" 23 #include "extensions/common/extension_messages.h"
24 #include "extensions/common/permissions/permissions_data.h"
24 #include "ipc/ipc_message_macros.h" 25 #include "ipc/ipc_message_macros.h"
25 26
26 namespace app_runtime = extensions::core_api::app_runtime; 27 namespace app_runtime = extensions::core_api::app_runtime;
27 28
28 using content::RenderFrameHost; 29 using content::RenderFrameHost;
29 using content::WebContents; 30 using content::WebContents;
30 using extensions::ExtensionHost; 31 using extensions::ExtensionHost;
31 32
32 namespace { 33 namespace {
33 34
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 ContextMenuDelegate* menu_delegate = 118 ContextMenuDelegate* menu_delegate =
118 ContextMenuDelegate::FromWebContents(guest_web_contents()); 119 ContextMenuDelegate::FromWebContents(guest_web_contents());
119 DCHECK(menu_delegate); 120 DCHECK(menu_delegate);
120 121
121 scoped_ptr<RenderViewContextMenu> menu = 122 scoped_ptr<RenderViewContextMenu> menu =
122 menu_delegate->BuildMenu(guest_web_contents(), params); 123 menu_delegate->BuildMenu(guest_web_contents(), params);
123 menu_delegate->ShowMenu(menu.Pass()); 124 menu_delegate->ShowMenu(menu.Pass());
124 return true; 125 return true;
125 } 126 }
126 127
128 bool AppViewGuest::CanEmbedderUseGuestView(
129 const std::string& embedder_extension_id) {
130 Profile* profile = Profile::FromBrowserContext(browser_context());
131 ExtensionService* service =
132 extensions::ExtensionSystem::Get(profile)->extension_service();
133 const extensions::Extension* embedder_extension =
134 service->GetExtensionById(embedder_extension_id, false);
135 const extensions::PermissionsData* permissions_data =
136 embedder_extension->permissions_data();
137 return permissions_data->HasAPIPermission(
138 extensions::APIPermission::kAppView);
139 }
140
127 void AppViewGuest::CreateWebContents( 141 void AppViewGuest::CreateWebContents(
128 const std::string& embedder_extension_id, 142 const std::string& embedder_extension_id,
129 int embedder_render_process_id, 143 int embedder_render_process_id,
130 const base::DictionaryValue& create_params, 144 const base::DictionaryValue& create_params,
131 const WebContentsCreatedCallback& callback) { 145 const WebContentsCreatedCallback& callback) {
132 std::string app_id; 146 std::string app_id;
133 if (!create_params.GetString(appview::kAppID, &app_id)) { 147 if (!create_params.GetString(appview::kAppID, &app_id)) {
134 callback.Run(NULL); 148 callback.Run(NULL);
135 return; 149 return;
136 } 150 }
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 return; 241 return;
228 } 242 }
229 243
230 scoped_ptr<base::DictionaryValue> embed_request(new base::DictionaryValue()); 244 scoped_ptr<base::DictionaryValue> embed_request(new base::DictionaryValue());
231 embed_request->SetInteger(appview::kGuestInstanceID, GetGuestInstanceID()); 245 embed_request->SetInteger(appview::kGuestInstanceID, GetGuestInstanceID());
232 embed_request->SetString(appview::kEmbedderID, embedder_extension_id()); 246 embed_request->SetString(appview::kEmbedderID, embedder_extension_id());
233 extensions::AppRuntimeEventRouter::DispatchOnEmbedRequestedEvent( 247 extensions::AppRuntimeEventRouter::DispatchOnEmbedRequestedEvent(
234 profile, embed_request.Pass(), extension_host->extension()); 248 profile, embed_request.Pass(), extension_host->extension());
235 } 249 }
236 250
OLDNEW
« no previous file with comments | « chrome/browser/guest_view/app_view/app_view_guest.h ('k') | chrome/browser/guest_view/guest_view_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698