Clean up a bit after SkPictureData/SkPicturePlayback split

Clean up a bit after SkPictureData/SkPicturePlayback split

This CL begins setting up the SkPicturePlayback split by simplifying the class and componentizing it a bit. It:
  fuses SkPictureData::OperationList into SkPicture::OperationList
  adds a handleOp method to SkPicturePlayback that can be reused by derived classes
  removes a couple debugging tools (ENABLE_TIME_DRAW & SPEW_CLIP_SKIPPING)

Committed: https://skia.googlesource.com/skia/+/3afef1f75f710b8f183113cdc5188416f7d01f28

[reed1, 2014-07-07 22:48:27]

api lgtm

https://codereview.chromium.org/378703002/diff/20001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/378703002/diff/20001/include/core/SkPicture.h...
include/core/SkPicture.h:275: SkTDArray<void*> fOps;
does this guy need to be public?

[mtklein, 2014-07-07 22:52:14]

LGTM.  Just some nits.

https://codereview.chromium.org/378703002/diff/20001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/378703002/diff/20001/include/core/SkPicture.h...
include/core/SkPicture.h:265: virtual ~OperationList() {}
No need for destructor anymore?

https://codereview.chromium.org/378703002/diff/20001/src/core/SkPicturePlayba...
File src/core/SkPicturePlayback.cpp (right):

https://codereview.chromium.org/378703002/diff/20001/src/core/SkPicturePlayba...
src/core/SkPicturePlayback.cpp:146: activeOps = &((const
SkPicture::OperationList*)activeOpsList.get())->fOps;
Isn't this cast a no-op now?

[robertphillips, 2014-07-08 12:50:43]

https://codereview.chromium.org/378703002/diff/20001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/378703002/diff/20001/include/core/SkPicture.h...
include/core/SkPicture.h:265: virtual ~OperationList() {}
On 2014/07/07 22:52:14, mtklein wrote:
> No need for destructor anymore?

Done.

https://codereview.chromium.org/378703002/diff/20001/include/core/SkPicture.h...
include/core/SkPicture.h:275: SkTDArray<void*> fOps;
Short term yes - without a whole lot of work. Long term, if the BBH classes
survive the transition to SkRecord then we should make this class stronger when
we update the BBH classes.

https://codereview.chromium.org/378703002/diff/20001/src/core/SkPicturePlayba...
File src/core/SkPicturePlayback.cpp (right):

https://codereview.chromium.org/378703002/diff/20001/src/core/SkPicturePlayba...
src/core/SkPicturePlayback.cpp:146: activeOps = &((const
SkPicture::OperationList*)activeOpsList.get())->fOps;
On 2014/07/07 22:52:14, mtklein wrote:
> Isn't this cast a no-op now?

Done.

[mtklein, 2014-07-08 12:55:13]

https://codereview.chromium.org/378703002/diff/60001/src/core/SkPicturePlayba...
File src/core/SkPicturePlayback.cpp (right):

https://codereview.chromium.org/378703002/diff/60001/src/core/SkPicturePlayba...
src/core/SkPicturePlayback.cpp:150: // Since the opList is valid we know it is
our derived class
Remove the comment too?

[robertphillips, 2014-07-08 12:56:21]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-07-08 12:57:11]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/378703002/6...

[commit-bot: I haz the power, 2014-07-08 13:12:29]

Change committed as 3afef1f75f710b8f183113cdc5188416f7d01f28