Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: include/core/SkPicture.h

Issue 378703002: Clean up a bit after SkPictureData/SkPicturePlayback split (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Update to ToT Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkPicture.cpp » ('j') | src/core/SkPicturePlayback.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkPicture.h
diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h
index d57af50611ca3f98a25a8d5dfe218862d4ffb1b3..6c486c978900683ab35b1adeaafc253864b30374 100644
--- a/include/core/SkPicture.h
+++ b/include/core/SkPicture.h
@@ -14,6 +14,7 @@
#include "SkDrawPictureCallback.h"
#include "SkImageDecoder.h"
#include "SkRefCnt.h"
+#include "SkTDArray.h"
#if SK_SUPPORT_GPU
class GrContext;
@@ -261,15 +262,15 @@ private:
// stream along with the CTMs needed for those operation.
class OperationList : ::SkNoncopyable {
public:
- virtual ~OperationList() {}
-
// The following three entry points should only be accessed if
// 'valid' returns true.
- virtual int numOps() const { SkASSERT(false); return 0; };
+ int numOps() const { return fOps.count(); }
// The offset in the picture of the operation to execute.
- virtual uint32_t offset(int index) const { SkASSERT(false); return 0; };
+ uint32_t offset(int index) const;
// The CTM that must be installed for the operation to behave correctly
- virtual const SkMatrix& matrix(int index) const { SkASSERT(false); return SkMatrix::I(); }
+ const SkMatrix& matrix(int index) const;
+
+ SkTDArray<void*> fOps;
};
/** PRIVATE / EXPERIMENTAL -- do not call
« no previous file with comments | « no previous file | src/core/SkPicture.cpp » ('j') | src/core/SkPicturePlayback.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698