Update GeolocationController to call startUpdating() / stopUpdating() only if needed

Update GeolocationController to call startUpdating() / stopUpdating() only if needed

Update GeolocationController to call startUpdating() / stopUpdating() only if needed
as some clients (e.g. the geolocation mock client) do not accept consecutive calls
to either of these methods.

This was done by introducing startUpdatingIfNeeded() / stopUpdatingIfNeeded() private
methods which update a boolean flag to avoid useless calls.

This fixes a possible assertion hit in Debug.

R=jochen
BUG=310326
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160480

[jsbell, 2013-10-23 22:35:29]

FWIW, fixes the issue on my win7 box.

[jochen (gone - plz use gerrit), 2013-10-24 12:44:57]

shouldn't it be possible to remove the test expectation now?

[Inactive, 2013-10-24 13:05:05]

On 2013/10/24 12:44:57, jochen wrote:
> shouldn't it be possible to remove the test expectation now?

Of course. The thing is that it was not in the TestExpectation when I uploaded
this CL :)
I will update the CL to unskip the test as well.

[Inactive, 2013-10-24 13:10:29]

On 2013/10/24 12:44:57, jochen wrote:
> shouldn't it be possible to remove the test expectation now?

Done in Patch Set 3.

[adamk, 2013-10-24 17:13:37]

lgtm

[commit-bot: I haz the power, 2013-10-24 17:14:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/37863002/90001

[commit-bot: I haz the power, 2013-10-24 17:33:31]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[Inactive, 2013-10-24 17:35:54]

On 2013/10/24 17:13:37, adamk wrote:
> lgtm

Thanks but it still needs review from a Source/modules OWNER :)

[Michael van Ouwerkerk, 2013-10-24 17:40:04]

lgtm

[Michael van Ouwerkerk, 2013-10-24 17:41:05]

On 2013/10/24 17:40:04, Michael van Ouwerkerk wrote:
> lgtm

Oh oops not a geolocation owner yet for the Blink part. lgtm anyway :-)

[abarth-chromium, 2013-10-24 17:51:49]

lgtm

[commit-bot: I haz the power, 2013-10-24 17:52:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/37863002/90001

[commit-bot: I haz the power, 2013-10-24 18:45:25]

Change committed as 160480