Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: Source/modules/geolocation/GeolocationController.h

Issue 37863002: Update GeolocationController to call startUpdating() / stopUpdating() only if needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Unskip test Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/modules/geolocation/GeolocationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/geolocation/GeolocationController.h
diff --git a/Source/modules/geolocation/GeolocationController.h b/Source/modules/geolocation/GeolocationController.h
index ba1617438ad759ce07cd133eddbb7ff303e33c27..50eaae892cb2f408b711075f9fca8e38e6efc7f6 100644
--- a/Source/modules/geolocation/GeolocationController.h
+++ b/Source/modules/geolocation/GeolocationController.h
@@ -58,8 +58,6 @@ public:
GeolocationPosition* lastPosition();
- GeolocationClient* client() { return m_client; }
-
// Inherited from PageLifecycleObserver.
virtual void pageVisibilityChanged() OVERRIDE;
@@ -69,6 +67,9 @@ public:
private:
GeolocationController(Page*, GeolocationClient*);
+ void startUpdatingIfNeeded();
+ void stopUpdatingIfNeeded();
+
GeolocationClient* m_client;
RefPtr<GeolocationPosition> m_lastPosition;
@@ -76,6 +77,7 @@ private:
// All observers; both those requesting high accuracy and those not.
ObserversSet m_observers;
ObserversSet m_highAccuracyObservers;
+ bool m_isClientUpdating;
};
} // namespace WebCore
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/modules/geolocation/GeolocationController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698