Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: chrome/browser/chromeos/events/event_rewriter_unittest.cc

Issue 378503007: Fix some surprising reverse key mappings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments (derat) Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/events/event_rewriter_unittest.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
index 4b3a244cb2714a2ccc907012a794130ae695f667..ad4d5e2e98d177e79deea8645a1d0f35b572beb8 100644
--- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc
+++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
@@ -816,6 +816,16 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapMany) {
{KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
{ui::VKEY_MENU, ui::EF_ALT_DOWN},
{ui::VKEY_CONTROL, ui::EF_CONTROL_DOWN}},
+ // Press Shift+comma. Verify that only the flags are changed.
+ // The X11 portion of the test addresses crbug.com/390263 by verifying
+ // that the X keycode remains that for ',<' and not for 105-key '<>'.
+ {KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
+ {ui::VKEY_OEM_COMMA, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN},
+ {ui::VKEY_OEM_COMMA, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN}},
+ // Press Shift+9. Verify that only the flags are changed.
+ {KeyTestCase::TEST_ALL, ui::ET_KEY_PRESSED,
+ {ui::VKEY_9, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN},
+ {ui::VKEY_9, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN}},
};
for (size_t i = 0; i < arraysize(a2c_tests); ++i) {
@@ -982,6 +992,7 @@ TEST_F(EventRewriterTest, TestRewriteDiamondKey) {
CheckKeyTestCase(1000 + i, &rewriter, tests[i]);
}
}
+
TEST_F(EventRewriterTest, TestRewriteDiamondKeyWithFlag) {
const CommandLine original_cl(*CommandLine::ForCurrentProcess());
CommandLine::ForCurrentProcess()->AppendSwitchASCII(

Powered by Google App Engine
This is Rietveld 408576698