Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 378353002: Pepper: Allow Compositor and VideoDecode on dev channel. (Closed)

Created:
6 years, 5 months ago by teravest
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Peng
Project:
chromium
Visibility:
Public.

Description

Pepper: Allow Compositor and VideoDecode on dev channel. An earlier change to narrow the whitelisting behavior for the Compositor and VideoDecode APIs enforced whitelisting, but removed the channel version check which permits use of these API on dev and canary builds of Chrome. https://codereview.chromium.org/346263006 This fixes that regression (and highlights the need for better testing for API permissions). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
teravest
6 years, 5 months ago (2014-07-09 15:39:12 UTC) #1
dmichael (off chromium)
lgtm
6 years, 5 months ago (2014-07-09 15:45:23 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-09 16:39:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/378353002/1
6 years, 5 months ago (2014-07-09 16:41:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 18:29:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 18:32:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/78884)
6 years, 5 months ago (2014-07-09 18:32:49 UTC) #7
teravest
+jochen for chrome/renderer/chrome_content_renderer_client.cc
6 years, 5 months ago (2014-07-09 18:40:33 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-10 11:23:39 UTC) #9
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-10 14:49:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/378353002/1
6 years, 5 months ago (2014-07-10 14:50:39 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 16:01:37 UTC) #12
Message was sent while issue was closed.
Change committed as 282333

Powered by Google App Engine
This is Rietveld 408576698