Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 346263006: Pepper: Narrow dev channel whitelisting behavior. (Closed)

Created:
6 years, 6 months ago by teravest
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pepper: Narrow dev channel whitelisting behavior. An earlier change whitelisted all "dev channel" Pepper APIs for two select application origins. This change narrows the whitelisting behavior to only grant access to the Compositor and VideoDecode APIs. This makes this instance of whitelisting easier to remove in the future. BUG=386743 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -18 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 4 chunks +63 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 chunk +9 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M content/renderer/pepper/content_renderer_pepper_host_factory.cc View 3 chunks +35 lines, -4 lines 0 comments Download
M content/renderer/pepper/message_channel.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 2 chunks +18 lines, -0 lines 0 comments Download
D ppapi/thunk/OWNERS View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
teravest
6 years, 6 months ago (2014-06-24 14:59:46 UTC) #1
dmichael (off chromium)
lgtm
6 years, 6 months ago (2014-06-24 15:41:55 UTC) #2
teravest
+pfeldman for content/shell +piman for other content/ +jln for security
6 years, 6 months ago (2014-06-24 17:48:38 UTC) #3
piman
lgtm
6 years, 6 months ago (2014-06-24 18:32:16 UTC) #4
pfeldman
content/shell rslgtm
6 years, 6 months ago (2014-06-24 20:22:33 UTC) #5
teravest
+jschuh -jln for removing the security restriction in ppapi/thunk/OWNERS.
6 years, 5 months ago (2014-07-02 16:38:55 UTC) #6
jschuh
lgtm
6 years, 5 months ago (2014-07-02 17:16:05 UTC) #7
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-02 17:42:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/346263006/1
6 years, 5 months ago (2014-07-02 17:43:20 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-02 19:27:48 UTC) #10
teravest
+jochen for chrome/renderer
6 years, 5 months ago (2014-07-02 19:30:19 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 19:31:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/77652)
6 years, 5 months ago (2014-07-02 19:31:09 UTC) #13
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-07 07:53:29 UTC) #14
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 5 months ago (2014-07-07 21:19:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/346263006/1
6 years, 5 months ago (2014-07-07 21:21:03 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 21:30:28 UTC) #17
Message was sent while issue was closed.
Change committed as 281588

Powered by Google App Engine
This is Rietveld 408576698