Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tools/perf/benchmarks/kraken.py

Issue 378323002: [Telemetry] Fix kraken result value type from r281894. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/kraken.py
diff --git a/tools/perf/benchmarks/kraken.py b/tools/perf/benchmarks/kraken.py
index b7addf650531bb88f914b4bc2cb7d538981391dc..8b4559ed924c78863a46c73a2708ca7713599d54 100644
--- a/tools/perf/benchmarks/kraken.py
+++ b/tools/perf/benchmarks/kraken.py
@@ -10,6 +10,7 @@ from metrics import power
from telemetry import benchmark
from telemetry.page import page_measurement
from telemetry.page import page_set
+from telemetry.value import list_of_scalar_values
from telemetry.value import scalar
@@ -48,9 +49,12 @@ decodeURIComponent(formElement.value.split("?")[1]);
for key in result_dict:
if key == 'v':
continue
- results.AddValue(scalar.ScalarValue(
+ results.AddValue(list_of_scalar_values.ListOfScalarValues(
results.current_page, key, 'ms', result_dict[key], important=False))
total += _Mean(result_dict[key])
+
+ # TODO(tonyg/nednguyen): This measurement shouldn't calculate Total. The
+ # results system should do that for us.
results.AddValue(scalar.ScalarValue(
results.current_page, 'Total', 'ms', total))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698