Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Side by Side Diff: tools/perf/benchmarks/kraken.py

Issue 378323002: [Telemetry] Fix kraken result value type from r281894. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Runs Mozilla's Kraken JavaScript benchmark.""" 5 """Runs Mozilla's Kraken JavaScript benchmark."""
6 6
7 import os 7 import os
8 8
9 from metrics import power 9 from metrics import power
10 from telemetry import benchmark 10 from telemetry import benchmark
11 from telemetry.page import page_measurement 11 from telemetry.page import page_measurement
12 from telemetry.page import page_set 12 from telemetry.page import page_set
13 from telemetry.value import list_of_scalar_values
13 from telemetry.value import scalar 14 from telemetry.value import scalar
14 15
15 16
16 def _Mean(l): 17 def _Mean(l):
17 return float(sum(l)) / len(l) if len(l) > 0 else 0.0 18 return float(sum(l)) / len(l) if len(l) > 0 else 0.0
18 19
19 20
20 class _KrakenMeasurement(page_measurement.PageMeasurement): 21 class _KrakenMeasurement(page_measurement.PageMeasurement):
21 def __init__(self): 22 def __init__(self):
22 super(_KrakenMeasurement, self).__init__() 23 super(_KrakenMeasurement, self).__init__()
(...skipping 18 matching lines...) Expand all
41 42
42 js_get_results = """ 43 js_get_results = """
43 var formElement = document.getElementsByTagName("input")[0]; 44 var formElement = document.getElementsByTagName("input")[0];
44 decodeURIComponent(formElement.value.split("?")[1]); 45 decodeURIComponent(formElement.value.split("?")[1]);
45 """ 46 """
46 result_dict = eval(tab.EvaluateJavaScript(js_get_results)) 47 result_dict = eval(tab.EvaluateJavaScript(js_get_results))
47 total = 0 48 total = 0
48 for key in result_dict: 49 for key in result_dict:
49 if key == 'v': 50 if key == 'v':
50 continue 51 continue
51 results.AddValue(scalar.ScalarValue( 52 results.AddValue(list_of_scalar_values.ListOfScalarValues(
52 results.current_page, key, 'ms', result_dict[key], important=False)) 53 results.current_page, key, 'ms', result_dict[key], important=False))
53 total += _Mean(result_dict[key]) 54 total += _Mean(result_dict[key])
55
56 # TODO(tonyg/nednguyen): This measurement shouldn't calculate Total. The
57 # results system should do that for us.
54 results.AddValue(scalar.ScalarValue( 58 results.AddValue(scalar.ScalarValue(
55 results.current_page, 'Total', 'ms', total)) 59 results.current_page, 'Total', 'ms', total))
56 60
57 61
58 class Kraken(benchmark.Benchmark): 62 class Kraken(benchmark.Benchmark):
59 """Mozilla's Kraken JavaScript benchmark.""" 63 """Mozilla's Kraken JavaScript benchmark."""
60 test = _KrakenMeasurement 64 test = _KrakenMeasurement
61 65
62 def CreatePageSet(self, options): 66 def CreatePageSet(self, options):
63 ps = page_set.PageSet( 67 ps = page_set.PageSet(
64 archive_data_file='../page_sets/data/kraken.json', 68 archive_data_file='../page_sets/data/kraken.json',
65 file_path=os.path.abspath(__file__)) 69 file_path=os.path.abspath(__file__))
66 ps.AddPageWithDefaultRunNavigate( 70 ps.AddPageWithDefaultRunNavigate(
67 'http://krakenbenchmark.mozilla.org/kraken-1.1/driver.html') 71 'http://krakenbenchmark.mozilla.org/kraken-1.1/driver.html')
68 return ps 72 return ps
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698