content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 378233002: [Android] Extend smart clip to return html along with text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 378233002: [Android] Extend smart clip to return html along with text (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: avoid build breakage Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentView.java ('k') | content/renderer/render_view_impl_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 45f6f8719ee76dd9984c0f4e0de72f83d035b204..681ed5a981b61aca5d575f8369d3bbfd0ee657e0 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -215,7 +215,7 @@ public class ContentViewCore

* extractSmartClipData are available.

public interface SmartClipDataListener {

- public void onSmartClipDataExtracted(String result, Rect cliprect);

+ public void onSmartClipDataExtracted(String text, String html, Rect clipRect);

}

/**

@@ -3085,9 +3085,9 @@ public class ContentViewCore

}

@CalledByNative

- private void onSmartClipDataExtracted(String result, Rect cliprect) {

+ private void onSmartClipDataExtracted(String text, String html, Rect clipRect) {

if (mSmartClipDataListener != null ) {

- mSmartClipDataListener.onSmartClipDataExtracted(result, cliprect);

+ mSmartClipDataListener.onSmartClipDataExtracted(text, html, clipRect);

}