content/public/android/java/src/org/chromium/content/browser/ContentView.java - Issue 378233002: [Android] Extend smart clip to return html along with text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 378233002: [Android] Extend smart clip to return html along with text (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: avoid build breakage Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/view_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

index ac54c16427643e9dac5981c6190ce6c08be2d646..0bc4e3985e6e3df2a58f0a008e16fad1db0edc31 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java

@@ -267,12 +267,13 @@ public class ContentView extends FrameLayout

return;

}

mContentViewCore.setSmartClipDataListener(new ContentViewCore.SmartClipDataListener() {

- public void onSmartClipDataExtracted(String text, Rect clipRect) {

+ public void onSmartClipDataExtracted(String text, String html, Rect clipRect) {

Bundle bundle = new Bundle();

bundle.putString("url", mContentViewCore.getWebContents().getVisibleUrl());

bundle.putString("title", mContentViewCore.getWebContents().getTitle());

- bundle.putParcelable("area", clipRect);

+ bundle.putParcelable("rect", clipRect);

bundle.putString("text", text);

+ bundle.putString("html", html);

try {

Message msg = Message.obtain(resultHandler, 0);

msg.setData(bundle);