GN: Put static libs next to .ninja files in output dir

GN: Put static libs next to .ninja files in output dir

This puts static libraries on mac next to their ninja files, i.e. in
locations like out/Debug/obj/base/libbase_static.a instead of directly
in the output directory. This matches what we do on other platforms and
avoids the need to give every static library a unique name in the GN
build. https://codereview.chromium.org/376773002/ has some discussion
of the history of why this is different in GYP.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282156

[brettw, 2014-07-09 05:07:46]

lgtm

[jamesr, 2014-07-09 15:42:34]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-09 15:43:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/378123002/1

[Nico, 2014-07-09 15:50:27]

Out of interest, why isn't this done on linux? (At least that's how it
looks in the snippet in this mail)


On Wed, Jul 9, 2014 at 8:43 AM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/jamesr@chromium.org/378123002/1
>
>
> https://codereview.chromium.org/378123002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jamesr, 2014-07-09 16:02:09]

It is. This only change behaviour on Mac which was the outlier here.
On Jul 9, 2014 8:50 AM, "Nico Weber" <thakis@chromium.org> wrote:

> Out of interest, why isn't this done on linux? (At least that's how it
> looks in the snippet in this mail)
>
>
> On Wed, Jul 9, 2014 at 8:43 AM, <commit-bot@chromium.org> wrote:
>
>> CQ is trying da patch. Follow status at
>>  https://chromium-status.appspot.com/cq/jamesr@chromium.org/378123002/1
>>
>>
>> https://codereview.chromium.org/378123002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-07-09 20:19:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-09 22:52:37]

Change committed as 282156

[chromium-reviews, 2014-07-10 06:47:13]

Oh - if you're asking why this branch isn't hit on linux it's because linux
puts shared_libraries (but not loadable_modules) into out/Foo/lib/..., not
out/Foo/.., in a branch slightly further down:

https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/ninja_hel...

...this could be simplified.


On Wed, Jul 9, 2014 at 8:50 AM, Nico Weber <thakis@chromium.org> wrote:

> Out of interest, why isn't this done on linux? (At least that's how it
> looks in the snippet in this mail)
>
>
> On Wed, Jul 9, 2014 at 8:43 AM, <commit-bot@chromium.org> wrote:
>
>> CQ is trying da patch. Follow status at
>>  https://chromium-status.appspot.com/cq/jamesr@chromium.org/378123002/1
>>
>>
>> https://codereview.chromium.org/378123002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.