Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: tools/gn/ninja_helper.cc

Issue 378123002: GN: Put static libs next to .ninja files in output dir (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_helper.cc
diff --git a/tools/gn/ninja_helper.cc b/tools/gn/ninja_helper.cc
index 75843ee453634be3d9c97fa9f8fcf8855d27b26a..cc03dd566703f0f010be2c0056c7305b23c1b43b 100644
--- a/tools/gn/ninja_helper.cc
+++ b/tools/gn/ninja_helper.cc
@@ -180,10 +180,7 @@ OutputFile NinjaHelper::GetTargetOutputFile(const Target* target) const {
// Binaries and loadable libraries go into the toolchain root.
if (target->output_type() == Target::EXECUTABLE ||
- (target->settings()->IsMac() &&
- (target->output_type() == Target::SHARED_LIBRARY ||
- target->output_type() == Target::STATIC_LIBRARY)) ||
- (target->settings()->IsWin() &&
+ ((target->settings()->IsMac() || target->settings()->IsWin()) &&
target->output_type() == Target::SHARED_LIBRARY)) {
// Generate a name like "<toolchain>/<prefix><name>.<extension>".
ret.value().append(prefix);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698