Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1928)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 378113003: Modifications to layout test framework so that it can work with browser_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Refactored browser_test.py by removing all the platform specific ports and created a class that cre… Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index 38a3061315e2b52ba801f7ba8c04d998f3fe29ad..1023c33f4f3e6993b38ef91caab1faedabe750ce 100644
--- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -49,7 +49,7 @@ _log = logging.getLogger(__name__)
def main(argv, stdout, stderr):
options, args = parse_args(argv)
- if options.platform and 'test' in options.platform:
+ if options.platform and 'test' in options.platform and not 'browser_test' in options.platform:
ivandavid 2014/07/10 22:39:09 Without this addition to the conditional, the fram
# It's a bit lame to import mocks into real code, but this allows the user
# to run tests against the test platform interactively, which is useful for
# debugging test failures.
@@ -263,6 +263,7 @@ def parse_args(args):
help="Enable the leak detection of DOM objects."),
optparse.make_option("--enable-sanitizer", action="store_true",
help="Only alert on sanitizer-related errors and crashes"),
+ optparse.make_option("--driver_name"),
Dirk Pranke 2014/07/10 23:37:13 --driver-name exists already on line 149. Presumab
ivandavid 2014/07/16 21:29:01 Oops. I was always using underscore rather than da
ivandavid 2014/07/16 21:29:01 Done.
]))
option_group_definitions.append(("Miscellaneous Options", [

Powered by Google App Engine
This is Rietveld 408576698