Tools/Scripts/webkitpy/layout_tests/port/factory.py - Issue 378113003: Modifications to layout test framework so that it can work with browser_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/factory.py

Issue 378113003: Modifications to layout test framework so that it can work with browser_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Refactored browser_test.py by removing all the platform specific ports and created a class that cre… Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py ('K') | « Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py ('k') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/layout_tests/port/factory.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/port/factory.py b/Tools/Scripts/webkitpy/layout_tests/port/factory.py

index db2144ba2c03d6948db46d38da0bc8bcfef759ab..8a4cd626dfd6f3d80d912377ad0f75bedfc17a9f 100644

--- a/Tools/Scripts/webkitpy/layout_tests/port/factory.py

+++ b/Tools/Scripts/webkitpy/layout_tests/port/factory.py

@@ -78,6 +78,7 @@ class PortFactory(object):

'win.WinPort',

'mock_drt.MockDRTPort',

'test.TestPort',

+ 'browser_test.BrowserTestPort',

)

def __init__(self, host):

@@ -107,6 +108,7 @@ class PortFactory(object):

for port_class in self.PORT_CLASSES:

module_name, class_name = port_class.rsplit('.', 1)

module = __import__(module_name, globals(), locals(), [], -1)

Dirk Pranke 2014/07/10 23:37:13 nit: delete the stray blank line?

ivandavid 2014/07/16 21:29:01 Done.

cls = module.__dict__[class_name]

if port_name.startswith(cls.port_name):

port_name = cls.determine_full_port_name(self._host, options, port_name)