Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: runtime/bin/vmservice/client/lib/src/app/application.dart

Issue 378113002: Improve script display in the observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/app/application.dart
diff --git a/runtime/bin/vmservice/client/lib/src/app/application.dart b/runtime/bin/vmservice/client/lib/src/app/application.dart
index 6eae10b67797fa92478c08444a616632100e213b..0bf208767a6b562945856c23aafb2050c0ff40f1 100644
--- a/runtime/bin/vmservice/client/lib/src/app/application.dart
+++ b/runtime/bin/vmservice/client/lib/src/app/application.dart
@@ -117,12 +117,17 @@ class ObservatoryApplication extends Observable {
}
void _visit(String url, String args) {
- // TODO(johnmccutchan): Pass [args] to pane.
+ var argsMap;
+ if (args == null) {
+ argsMap = {};
+ } else {
+ argsMap = Uri.splitQueryString(args);
+ }
for (var i = 0; i < _paneRegistry.length; i++) {
var pane = _paneRegistry[i];
if (pane.canVisit(url)) {
_installPane(pane);
- pane.visit(url);
+ pane.visit(url, argsMap);
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698