Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: runtime/bin/vmservice/client/lib/src/app/pane.dart

Issue 378113002: Improve script display in the observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/app/pane.dart
diff --git a/runtime/bin/vmservice/client/lib/src/app/pane.dart b/runtime/bin/vmservice/client/lib/src/app/pane.dart
index e99906417672657c97e5ab6957f43b543453f98c..6daf449e5b9e27be4916e7a13167b4605d7126a3 100644
--- a/runtime/bin/vmservice/client/lib/src/app/pane.dart
+++ b/runtime/bin/vmservice/client/lib/src/app/pane.dart
@@ -27,7 +27,7 @@ abstract class Pane extends Observable {
/// Called when the pane should update its state based on [url].
/// NOTE: Only called when the pane is installed.
- void visit(String url);
+ void visit(String url, Map args);
/// Called to test whether this pane can visit [url].
bool canVisit(String url);
@@ -44,7 +44,7 @@ class ServiceObjectPane extends Pane {
}
}
- void visit(String url) {
+ void visit(String url, Map args) {
assert(element != null);
assert(canVisit(url));
if (url == '') {
@@ -55,6 +55,7 @@ class ServiceObjectPane extends Pane {
app.vm.get(url).then((obj) {
ServiceObjectViewElement pane = element;
pane.object = obj;
+ pane.args = toObservable(args);
}).catchError((e) {
Logger.root.severe('ServiceObjectPane visit error: $e');
});
@@ -76,7 +77,7 @@ class ClassTreePane extends Pane {
}
}
- void visit(String url) {
+ void visit(String url, Map args) {
assert(element != null);
assert(canVisit(url));
// ClassTree urls are 'class-tree/isolate-id', chop off prefix, leaving
@@ -108,7 +109,7 @@ class ErrorViewPane extends Pane {
}
}
- void visit(String url) {
+ void visit(String url, Map args) {
assert(element != null);
assert(canVisit(url));
(element as ServiceObjectViewElement).object = app.lastErrorOrException;
@@ -127,7 +128,7 @@ class VMConnectPane extends Pane {
assert(element != null);
}
- void visit(String url) {
+ void visit(String url, Map args) {
assert(element != null);
assert(canVisit(url));
}

Powered by Google App Engine
This is Rietveld 408576698