Adding size parameter to read array functions

src/core/SkFlattenableBuffers.cpp

Index: src/core/SkFlattenableBuffers.cpp
diff --git a/src/core/SkFlattenableBuffers.cpp b/src/core/SkFlattenableBuffers.cpp
index dbf66da7ce88bcbe3bf4d3fa61609bd2684c567c..54d18d1c2f03eabcb137cfd289230f97b8c1ca17 100644
--- a/src/core/SkFlattenableBuffers.cpp
+++ b/src/core/SkFlattenableBuffers.cpp
@@ -37,7 +37,7 @@ SkFlattenableReadBuffer::~SkFlattenableReadBuffer() { }
 void* SkFlattenableReadBuffer::readFunctionPtr() {
     void* proc;
     SkASSERT(sizeof(void*) == this->getArrayCount());
-    this->readByteArray(&proc);
+    this->readByteArray(&proc, sizeof(void*));

[Tom Sepez, 2013/11/08 20:59:01]

drive-by: Code like this always scares the crap out of us, because although it
looks like this may not get called in the inter-process case based upon flags in
the current implementation, something might change introducing the easiest
possible escape ever. Please try to remove this and use another mechanism even
in the intra-process case.
Besides, the code is not correct in that casting a function to void* is wrong
per C specs (see e.g.
http://stackoverflow.com/questions/1096341/function-pointers-casting-in-c).

[sugoi, 2013/11/08 21:31:16]

Thanks for your comment ! Yes, code like this was one of the main motivations
for the rewrite of a new more secure serialization class in skia (see
SkValidatingReadBuffer). The original serialization code in Skia was written for
speed, not for security, which is why it had to be redesigned and rewritten. If
performance allows it, maybe we could eventually modify Skia to only use the
secure serialization, but there's still code using the old one for now (in Skia,
not in Chromium, AFAIK). Maybe we could find a way to make these functions only
accessible in Skia (as in #ifdefed out and not even compiled in Chrome, since
Chrome will not use this). What do you think ?

     return proc;
 }