Issue 377803003: Change FileArg syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 377803003: Change FileArg syntax (Closed)

Created:
6 years, 5 months ago by cjhopman

Modified:
6 years, 5 months ago

Reviewers:
brettw, newt (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-resources

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change FileArg syntax This changes the syntax from: @(filepath:key0:key1) to: @FileArg(filepath:key0:key1) This should make it much easier for someone who encounters this syntax to figure out what it is (currently a `git grep FileArg` returns only results about/using this feature). Also changes it to use a simple regex search instead of adhoc stuff. BUG=359249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283484

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -16 lines)			Patch
M	build/android/gyp/util/build_utils.py	View	1	4 chunks	+10 lines, -11 lines	0 comments	Download
M	build/android/gyp/write_build_config.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/config/android/internal_rules.gni	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/377803003/20001

6 years, 5 months ago (2014-07-16 01:21:03 UTC) #6

Message was sent while issue was closed.

Change committed as 283484

Expand Messages | Collapse Messages