build/android/gyp/write_build_config.py - Issue 377803003: Change FileArg syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/write_build_config.py

Issue 377803003: Change FileArg syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-resources

Patch Set: Rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/write_build_config.py

diff --git a/build/android/gyp/write_build_config.py b/build/android/gyp/write_build_config.py

index 794e6a321018d0bbc82977fe7b73439222f3cef0..01f9fb347bb3256767a7ccbc80bfafce71c53c3d 100755

--- a/build/android/gyp/write_build_config.py

+++ b/build/android/gyp/write_build_config.py

@@ -20,7 +20,7 @@ Android build scripts should not refer to the build_config directly, and the

build specification should instead pass information in using the special

file-arg syntax (see build_utils.py:ExpandFileArgs). That syntax allows passing

of values in a json dict in a file and looks like this:

- --python-arg=@(build_config_path:javac:classpath)

+ --python-arg=@FileArg(build_config_path:javac:classpath)

Note: If paths to input files are passed in this way, it is important that:

1. inputs/deps of the action ensure that the files are available the first

« no previous file with comments | « build/android/gyp/util/build_utils.py ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »