extensions/browser/extension_function_dispatcher.cc - Issue 377753003: Remove GetContexts() from the public interface of extensions::Feature. It was

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function_dispatcher.cc

Issue 377753003: Remove GetContexts() from the public interface of extensions::Feature. It was (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/extension_api_unittest/privileged_api_features.json ('K') | « extensions/browser/event_router.cc ('k') | extensions/common/extension_api.h » ('j') | extensions/common/extension_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function_dispatcher.cc

diff --git a/extensions/browser/extension_function_dispatcher.cc b/extensions/browser/extension_function_dispatcher.cc

index fb3b50d66b28fedf401c357d85df84a44ec02079..d02b7990da398a10222cb89ce27c452ce540bfea 100644

--- a/extensions/browser/extension_function_dispatcher.cc

+++ b/extensions/browser/extension_function_dispatcher.cc

@@ -474,7 +474,7 @@ ExtensionFunction* ExtensionFunctionDispatcher::CreateExtensionFunction(

// Privileged APIs can only be called from the process the extension

// is running in.

- if (allowed && api->IsPrivileged(params.name))

+ if (allowed && !api->IsAvailableInUntrustedContext(params.name, extension))

allowed = process_map.Contains(extension->id(), requesting_process_id);

if (!allowed) {