extensions/browser/event_router.cc - Issue 377753003: Remove GetContexts() from the public interface of extensions::Feature. It was

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/event_router.cc

Issue 377753003: Remove GetContexts() from the public interface of extensions::Feature. It was (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/extension_api_unittest/privileged_api_features.json ('K') | « chrome/test/data/extensions/extension_api_unittest/privileged_api_features.json ('k') | extensions/browser/extension_function_dispatcher.cc » ('j') | extensions/common/extension_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/event_router.cc

diff --git a/extensions/browser/event_router.cc b/extensions/browser/event_router.cc

index 3c6679fb997e45e2f4412eea8d9b84d8dcf3c63c..14cc9d6ba4e7a012290404bb71d176660ca18d98 100644

--- a/extensions/browser/event_router.cc

+++ b/extensions/browser/event_router.cc

@@ -525,8 +525,9 @@ void EventRouter::DispatchEventToProcess(const std::string& extension_id,

ProcessMap* process_map = ProcessMap::Get(listener_context);

// If the event is privileged, only send to extension processes. Otherwise,

// it's OK to send to normal renderers (e.g., for content scripts).

- if (ExtensionAPI::GetSharedInstance()->IsPrivileged(event->event_name) &&

- !process_map->Contains(extension->id(), process->GetID())) {

+ if (!process_map->Contains(extension->id(), process->GetID()) &&

+ !ExtensionAPI::GetSharedInstance()->IsAvailableInUntrustedContext(

+ event->event_name, extension)) {

return;

}