Issue 377723003: Remove some unnecessary heap allocations and copies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 377723003: Remove some unnecessary heap allocations and copies. (Closed)

Created:
6 years, 5 months ago by Evan Stade

Modified:
6 years, 5 months ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove some unnecessary heap allocations and copies. - Remove some calls to base::CreateStringValue - pass some things by const ref instead of copying or scoped_ptr BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281873

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -47 lines)			Patch
M	chrome/browser/devtools/devtools_targets_ui.h	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/devtools/devtools_targets_ui.cc	View	17 chunks	+23 lines, -21 lines	0 comments	Download
M	chrome/browser/devtools/devtools_ui_bindings.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/devtools/devtools_ui_bindings.cc	View	3 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/inspect_ui.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/377723003/20001

6 years, 5 months ago (2014-07-08 18:13:41 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-08 19:27:58 UTC) #5

Message was sent while issue was closed.

Change committed as 281873