Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: chrome/browser/devtools/devtools_targets_ui.h

Issue 377723003: Remove some unnecessary heap allocations and copies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: devtools only Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_targets_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_targets_ui.h
diff --git a/chrome/browser/devtools/devtools_targets_ui.h b/chrome/browser/devtools/devtools_targets_ui.h
index 7d4db83abd33f1e232f126bb659d4ff2736eb946..38d184318504c916d2d85fb046fd46e6290b415b 100644
--- a/chrome/browser/devtools/devtools_targets_ui.h
+++ b/chrome/browser/devtools/devtools_targets_ui.h
@@ -23,22 +23,23 @@ class Profile;
class DevToolsTargetsUIHandler {
public:
typedef base::Callback<void(const std::string&,
- scoped_ptr<base::ListValue>)> Callback;
+ const base::ListValue&)> Callback;
typedef base::Callback<void(DevToolsTargetImpl*)> TargetCallback;
- DevToolsTargetsUIHandler(const std::string& source_id, Callback callback);
+ DevToolsTargetsUIHandler(const std::string& source_id,
+ const Callback& callback);
virtual ~DevToolsTargetsUIHandler();
std::string source_id() const { return source_id_; }
static scoped_ptr<DevToolsTargetsUIHandler> CreateForRenderers(
- Callback callback);
+ const Callback& callback);
static scoped_ptr<DevToolsTargetsUIHandler> CreateForWorkers(
- Callback callback);
+ const Callback& callback);
static scoped_ptr<DevToolsTargetsUIHandler> CreateForAdb(
- Callback callback, Profile* profile);
+ const Callback& callback, Profile* profile);
DevToolsTargetImpl* GetTarget(const std::string& target_id);
@@ -50,7 +51,7 @@ class DevToolsTargetsUIHandler {
protected:
base::DictionaryValue* Serialize(const DevToolsTargetImpl& target);
- void SendSerializedTargets(scoped_ptr<base::ListValue> list);
+ void SendSerializedTargets(const base::ListValue& list);
typedef std::map<std::string, DevToolsTargetImpl*> TargetMap;
TargetMap targets_;
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_targets_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698