Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 377723002: Fixes for re-enabling more MSVC level 4 warnings: content/ edition (Closed)

Created:
6 years, 5 months ago by Peter Kasting
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Fixes for re-enabling more MSVC level 4 warnings: content/ edition This contains fixes for the following sorts of issues: * Signedness mismatch * Possibly-uninitialized local variable * Assignment inside conditional * Nonstandard extension: unnamed struct/union This also contains a very small number of other cleanups/simplifications to nearby code. BUG=81439 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -43 lines) Patch
M content/child/npapi/plugin_instance.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/child/webcrypto/jwk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/shared_crypto.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/sandbox_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/ssl_status_serialization.cc View 1 chunk +18 lines, -20 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Peter Kasting
6 years, 5 months ago (2014-07-07 21:44:45 UTC) #1
Peter Kasting
Friendly ping
6 years, 5 months ago (2014-07-11 17:22:25 UTC) #2
Peter Kasting
Brett, can you review this? John seems to be unresponsive (maybe away).
6 years, 5 months ago (2014-07-14 20:49:42 UTC) #3
brettw
lgtm
6 years, 5 months ago (2014-07-14 21:08:28 UTC) #4
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 5 months ago (2014-07-14 21:09:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/377723002/1
6 years, 5 months ago (2014-07-14 21:10:36 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 23:57:18 UTC) #7
Peter Kasting
+cpu for sandbox_win.cc
6 years, 5 months ago (2014-07-14 23:59:47 UTC) #8
cpu_(ooo_6.6-7.5)
lgtm
6 years, 5 months ago (2014-07-15 00:26:07 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 06:50:43 UTC) #10
Message was sent while issue was closed.
Change committed as 283161

Powered by Google App Engine
This is Rietveld 408576698