Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: content/common/ssl_status_serialization.cc

Issue 377723002: Fixes for re-enabling more MSVC level 4 warnings: content/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/sandbox_win.cc ('k') | content/worker/worker_webkitplatformsupport_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/ssl_status_serialization.cc
diff --git a/content/common/ssl_status_serialization.cc b/content/common/ssl_status_serialization.cc
index 5543c35d4e36d173dcae3038f76f0fa2f46e6a50..d10b1b8a7e47a33cb967f41585a68d96b5626b6f 100644
--- a/content/common/ssl_status_serialization.cc
+++ b/content/common/ssl_status_serialization.cc
@@ -53,29 +53,27 @@ bool DeserializeSecurityInfo(
Pickle pickle(state.data(), static_cast<int>(state.size()));
PickleIterator iter(pickle);
- bool pickle_read_ok = pickle.ReadInt(&iter, cert_id) &&
- pickle.ReadUInt32(&iter, cert_status) &&
- pickle.ReadInt(&iter, security_bits) &&
- pickle.ReadInt(&iter, ssl_connection_status);
- if (!pickle_read_ok)
- return pickle_read_ok;
-
int num_scts_to_read;
- pickle_read_ok = pickle.ReadInt(&iter, &num_scts_to_read);
- int id;
- uint16 status;
- for (; pickle_read_ok && num_scts_to_read > 0; --num_scts_to_read) {
- pickle_read_ok = pickle.ReadInt(&iter, &id) &&
- pickle.ReadUInt16(&iter, &status);
- if (pickle_read_ok) {
- signed_certificate_timestamp_ids->push_back(
- SignedCertificateTimestampIDAndStatus(
- id,
- static_cast<net::ct::SCTVerifyStatus>(status)));
- }
+ if (!pickle.ReadInt(&iter, cert_id) ||
+ !pickle.ReadUInt32(&iter, cert_status) ||
+ !pickle.ReadInt(&iter, security_bits) ||
+ !pickle.ReadInt(&iter, ssl_connection_status) ||
+ !pickle.ReadInt(&iter, &num_scts_to_read))
+ return false;
+
+ for (; num_scts_to_read > 0; --num_scts_to_read) {
+ int id;
+ uint16 status;
+ if (!pickle.ReadInt(&iter, &id) ||
+ !pickle.ReadUInt16(&iter, &status))
+ return false;
+ signed_certificate_timestamp_ids->push_back(
+ SignedCertificateTimestampIDAndStatus(
+ id,
+ static_cast<net::ct::SCTVerifyStatus>(status)));
}
- return pickle_read_ok;
+ return true;
}
} // namespace content
« no previous file with comments | « content/common/sandbox_win.cc ('k') | content/worker/worker_webkitplatformsupport_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698