chrome/common/favicon/favicon_url_parser.cc - Issue 377683002: Fixes for re-enabling more MSVC level 4 warnings: chrome/ edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/favicon/favicon_url_parser.cc

Issue 377683002: Fixes for re-enabling more MSVC level 4 warnings: chrome/ edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/favicon/favicon_url_parser.cc

diff --git a/chrome/common/favicon/favicon_url_parser.cc b/chrome/common/favicon/favicon_url_parser.cc

index 434642d7555547017ebb0435ffd3b70cb3cb0360..16d78af4e9f816f4b8984310c7bd4518c5fe9118 100644

--- a/chrome/common/favicon/favicon_url_parser.cc

+++ b/chrome/common/favicon/favicon_url_parser.cc

@@ -39,7 +39,7 @@ bool ParseFaviconPath(const std::string& path,

parsed->url = "";

parsed->size_in_dip = gfx::kFaviconSize;

parsed->device_scale_factor = 1.0f;

- parsed->path_index = -1;

+ parsed->path_index = std::string::npos;

if (path.empty())

return false;