Fixes for re-enabling more MSVC level 4 warnings: chrome/ edition

chrome/common/favicon/favicon_url_parser.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/favicon/favicon_url_parser.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "components/favicon_base/favicon_types.h"
 #include "net/url_request/url_request.h"
 #include "ui/base/webui/web_ui_util.h"
@@ skipping 21 matching lines @@
 
 namespace chrome {
 
 bool ParseFaviconPath(const std::string& path,
                       int icon_types,
                       ParsedFaviconPath* parsed) {
   parsed->is_icon_url = false;
   parsed->url = "";
   parsed->size_in_dip = gfx::kFaviconSize;
   parsed->device_scale_factor = 1.0f;
-  parsed->path_index = -1;
+  parsed->path_index = std::string::npos;
 
   if (path.empty())
     return false;
 
   size_t parsed_index = 0;
   if (HasSubstringAt(path, parsed_index, kLargestParameter)) {
     parsed_index += strlen(kLargestParameter);
     parsed->size_in_dip = 0;
   } else if (HasSubstringAt(path, parsed_index, kSizeParameter)) {
     parsed_index += strlen(kSizeParameter);
@@ skipping 67 matching lines @@
   // to translate favicon URLs using advanced parameters.
   // Example:
   //   "chrome-search://favicon/size/16@2x/<renderer-id>/<most-visited-id>"
   // would be translated to:
   //   "chrome-search://favicon/size/16@2x/<most-visited-item-with-given-id>".
   parsed->path_index = parsed_index;
   return true;
 }
 
 }  // namespace chrome