Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3729)

Unified Diff: chrome/browser/ui/libgtk2ui/gtk2_util.cc

Issue 377423003: Lots of random cleanups, mostly for native_theme_win.cc: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Build fix #2, for reals Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/native_theme/native_theme.h » ('j') | ui/native_theme/native_theme_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/libgtk2ui/gtk2_util.cc
diff --git a/chrome/browser/ui/libgtk2ui/gtk2_util.cc b/chrome/browser/ui/libgtk2ui/gtk2_util.cc
index 3138437fde2ed71b25511d10653f94e8ff3fc04d..f717995568dd2c416a176aa448d9baf7db279b81 100644
--- a/chrome/browser/ui/libgtk2ui/gtk2_util.cc
+++ b/chrome/browser/ui/libgtk2ui/gtk2_util.cc
@@ -136,9 +136,8 @@ GtkStateType GetGtkState(ui::NativeTheme::State state) {
case ui::NativeTheme::kHovered: return GTK_STATE_PRELIGHT;
case ui::NativeTheme::kNormal: return GTK_STATE_NORMAL;
case ui::NativeTheme::kPressed: return GTK_STATE_ACTIVE;
- case ui::NativeTheme::kMaxState: NOTREACHED() << "Unknown state: " << state;
sky 2014/07/10 16:05:39 I like the old version better as if a new state is
Peter Kasting 2014/07/10 18:23:15 That's correct, but you do still get a runtime err
sky 2014/07/10 19:33:09 I way prefer the compile time error than a runtime
Peter Kasting 2014/07/10 21:44:25 Done.
+ default: NOTREACHED(); return GTK_STATE_NORMAL;
}
- return GTK_STATE_NORMAL;
}
} // namespace libgtk2ui
« no previous file with comments | « no previous file | ui/native_theme/native_theme.h » ('j') | ui/native_theme/native_theme_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698