Lots of random cleanups, mostly for native_theme_win.cc:

chrome/browser/ui/libgtk2ui/gtk2_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/libgtk2ui/gtk2_util.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkx.h>
 #include <gtk/gtk.h>
 
@@ skipping 118 matching lines @@
 void ClearAuraTransientParent(GtkWidget* dialog) {
   g_object_set_data(G_OBJECT(dialog), kAuraTransientParent, NULL);
 }
 
 GtkStateType GetGtkState(ui::NativeTheme::State state) {
   switch (state) {
     case ui::NativeTheme::kDisabled: return GTK_STATE_INSENSITIVE;
     case ui::NativeTheme::kHovered:  return GTK_STATE_PRELIGHT;
     case ui::NativeTheme::kNormal:   return GTK_STATE_NORMAL;
     case ui::NativeTheme::kPressed:  return GTK_STATE_ACTIVE;
-    case ui::NativeTheme::kMaxState: NOTREACHED() << "Unknown state: " << state;

[sky, 2014/07/10 16:05:39]

I like the old version better as if a new state is added without updating this
switch you get a compile error. That isn't the case with the new code.

[Peter Kasting, 2014/07/10 18:23:15]

That's correct, but you do still get a runtime error from the NOTREACHED(). 
Given that this function is called for every drawable object, there's no way
that will escape notice.  As long as that's the case, this doesn't seem worse to
me.

[sky, 2014/07/10 19:33:09]

I way prefer the compile time error than a runtime error here.

[Peter Kasting, 2014/07/10 21:44:25]

Done.

+    default:                         NOTREACHED(); return GTK_STATE_NORMAL;
   }
-  return GTK_STATE_NORMAL;
 }
 
 }  // namespace libgtk2ui