Chromium Code Reviews| Index: chrome/browser/ui/libgtk2ui/gtk2_util.cc |
| diff --git a/chrome/browser/ui/libgtk2ui/gtk2_util.cc b/chrome/browser/ui/libgtk2ui/gtk2_util.cc |
| index 3138437fde2ed71b25511d10653f94e8ff3fc04d..f717995568dd2c416a176aa448d9baf7db279b81 100644 |
| --- a/chrome/browser/ui/libgtk2ui/gtk2_util.cc |
| +++ b/chrome/browser/ui/libgtk2ui/gtk2_util.cc |
| @@ -136,9 +136,8 @@ GtkStateType GetGtkState(ui::NativeTheme::State state) { |
| case ui::NativeTheme::kHovered: return GTK_STATE_PRELIGHT; |
| case ui::NativeTheme::kNormal: return GTK_STATE_NORMAL; |
| case ui::NativeTheme::kPressed: return GTK_STATE_ACTIVE; |
| - case ui::NativeTheme::kMaxState: NOTREACHED() << "Unknown state: " << state; |
|
sky
2014/07/10 16:05:39
I like the old version better as if a new state is
Peter Kasting
2014/07/10 18:23:15
That's correct, but you do still get a runtime err
sky
2014/07/10 19:33:09
I way prefer the compile time error than a runtime
Peter Kasting
2014/07/10 21:44:25
Done.
|
| + default: NOTREACHED(); return GTK_STATE_NORMAL; |
| } |
| - return GTK_STATE_NORMAL; |
| } |
| } // namespace libgtk2ui |