Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 377393002: Add more components to GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add more components to GN build. domain_reliability favicon history url_fixer R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -23 lines) Patch
M chrome/browser/BUILD.gn View 4 chunks +6 lines, -6 lines 0 comments Download
M components/BUILD.gn View 3 chunks +12 lines, -0 lines 0 comments Download
M components/domain_reliability.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A components/domain_reliability/BUILD.gn View 1 chunk +62 lines, -0 lines 0 comments Download
M components/favicon.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A components/favicon/core/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
M components/history.gypi View 5 chunks +6 lines, -0 lines 0 comments Download
A components/history/core/browser/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
A + components/history/core/common/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/history/core/test/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
M components/url_fixer.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A + components/url_fixer/BUILD.gn View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-07-09 19:33:51 UTC) #1
jamesr
lgtm
6 years, 5 months ago (2014-07-09 19:47:19 UTC) #2
brettw
6 years, 5 months ago (2014-07-09 21:10:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r282120.

Powered by Google App Engine
This is Rietveld 408576698