Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon.gypi

Issue 377393002: Add more components to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/BUILD.gn ('k') | components/favicon/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon.gypi
diff --git a/components/favicon.gypi b/components/favicon.gypi
index 32b64553847b7037ea70ee5bd186f25f259adca1..262bd2b4fe60cbbba32eb76dd4f52a29b896acf6 100644
--- a/components/favicon.gypi
+++ b/components/favicon.gypi
@@ -5,6 +5,7 @@
{
'targets': [
{
+ # GN version: //components/favicon/core
'target_name': 'favicon_core',
'type': 'static_library',
'dependencies': [
@@ -13,6 +14,7 @@
'keyed_service_core',
],
'sources': [
+ # Note: sources list duplicated in GN build.
'favicon/core/browser/favicon_client.h',
'favicon/core/favicon_driver.h',
'favicon/core/favicon_url.cc',
« no previous file with comments | « components/domain_reliability/BUILD.gn ('k') | components/favicon/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698