Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 377353002: Fixes for re-enabling more MSVC level 4 warnings: pdfium/ edition (try 2) (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
Peter Kasting
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fixes for re-enabling more MSVC level 4 warnings: pdfium/ edition (try 2) This contains fixes for the following sorts of issues: * Nonstandard extension: unnamed struct/union This also changes the signature of FPDF_FillRect() to enable the cleanest possible changes in https://codereview.chromium.org/372273005 . BUG=81439 TEST=none Original patch by Peter Kasting <pkasting@chromium.org>; Original code review: https://codereview.chromium.org/376003003/ R=pkasting@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/532a6a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -26 lines) Patch
M core/include/fxcrt/fx_ucd.h View 1 chunk +0 lines, -14 lines 0 comments Download
M fpdfsdk/include/fpdfview.h View 2 chunks +2 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M samples/pdfium_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Yesterday's pdfium DEPS roll landed safely, so let's try again.
6 years, 4 months ago (2014-07-09 18:44:19 UTC) #1
Peter Kasting
RSLGTM
6 years, 4 months ago (2014-07-09 18:47:02 UTC) #2
Lei Zhang
6 years, 4 months ago (2014-07-09 18:47:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r532a6a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698