Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 376003003: Fixes for re-enabling more MSVC level 4 warnings: pdfium/ edition (Closed)

Created:
6 years, 4 months ago by Peter Kasting
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang, Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fixes for re-enabling more MSVC level 4 warnings: pdfium/ edition This contains fixes for the following sorts of issues: * Nonstandard extension: unnamed struct/union This also changes the signature of FPDF_FillRect() to enable the cleanest possible changes in https://codereview.chromium.org/372273005 . BUG=81439 TEST=none

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix number of tabs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -26 lines) Patch
M core/include/fxcrt/fx_ucd.h View 1 chunk +0 lines, -14 lines 0 comments Download
M fpdfsdk/include/fpdfview.h View 1 2 chunks +2 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M samples/pdfium_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
https://codereview.chromium.org/376003003/diff/1/core/include/fxcrt/fx_ucd.h File core/include/fxcrt/fx_ucd.h (left): https://codereview.chromium.org/376003003/diff/1/core/include/fxcrt/fx_ucd.h#oldcode91 core/include/fxcrt/fx_ucd.h:91: typedef struct _FX_CHARPROPERTIES { This doesn't seem to be ...
6 years, 4 months ago (2014-07-08 21:28:29 UTC) #1
Lei Zhang
Bo: Do you see any problems with changing FPDF_FillRect() ?
6 years, 4 months ago (2014-07-08 21:38:23 UTC) #2
Bo Xu
On 2014/07/08 21:38:23, Lei Zhang wrote: > Bo: Do you see any problems with changing ...
6 years, 4 months ago (2014-07-08 23:05:27 UTC) #3
Lei Zhang
CL for landing: https://codereview.chromium.org/372383004/ PTAL
6 years, 4 months ago (2014-07-08 23:25:32 UTC) #4
Peter Kasting
6 years, 4 months ago (2014-07-08 23:37:44 UTC) #5
On 2014/07/08 23:25:32, Lei Zhang wrote:
> CL for landing: https://codereview.chromium.org/372383004/

Closing in favor of that.

Powered by Google App Engine
This is Rietveld 408576698