Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 377263003: Revert of Make GrGLConfigConversionEffect work for Imagination and some other GPUs. (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Make GrGLConfigConversionEffect work for Imagination and some other GPUs. (https://codereview.chromium.org/277323002/) Reason for revert: Need to only use the highp variations on GLES contexts not GL contexts. http://108.170.220.120:10117/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/builds/3398/steps/RunTests/logs/stdio Original issue's description: > Make GrGLConfigConversionEffect work for Imagination and some other GPUs. > > BUG=372341 > > Committed: https://skia.googlesource.com/skia/+/93cf46f7d687128d2ad05762bd65fea6c4539553 TBR= NOTREECHECKS=true NOTRY=true BUG=372341 Committed: https://skia.googlesource.com/skia/+/79fd2161448be2e6733281ef9ccb8d89c0c169a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
M src/gpu/effects/GrConfigConversionEffect.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 3 chunks +0 lines, -33 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
bsalomon
Created Revert of Make GrGLConfigConversionEffect work for Imagination and some other GPUs.
6 years, 5 months ago (2014-07-09 15:04:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/377263003/1
6 years, 5 months ago (2014-07-09 15:05:01 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 15:05:02 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 5 months ago (2014-07-09 15:05:02 UTC) #4
bsalomon
Can someone give an LGTM? I don't understand why that should be necessary. Ravi, is ...
6 years, 5 months ago (2014-07-09 15:07:24 UTC) #5
bsalomon
Adding the sheriff.
6 years, 5 months ago (2014-07-09 15:07:59 UTC) #6
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 5 months ago (2014-07-09 15:08:15 UTC) #7
jcgregorio
The CQ bit was unchecked by jcgregorio@google.com
6 years, 5 months ago (2014-07-09 15:08:19 UTC) #8
jcgregorio
On 2014/07/09 15:07:59, bsalomon wrote: > Adding the sheriff. LGTM
6 years, 5 months ago (2014-07-09 15:08:24 UTC) #9
rmistry
On 2014/07/09 15:07:24, bsalomon wrote: > Can someone give an LGTM? I don't understand why ...
6 years, 5 months ago (2014-07-09 15:09:08 UTC) #10
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-09 15:13:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/377263003/1
6 years, 5 months ago (2014-07-09 15:14:26 UTC) #12
commit-bot: I haz the power
Change committed as 79fd2161448be2e6733281ef9ccb8d89c0c169a2
6 years, 5 months ago (2014-07-09 15:14:44 UTC) #13
bsalomon
On 2014/07/09 15:09:08, rmistry wrote: > On 2014/07/09 15:07:24, bsalomon wrote: > > Can someone ...
6 years, 5 months ago (2014-07-09 15:28:02 UTC) #14
rmistry
6 years, 5 months ago (2014-07-09 15:30:44 UTC) #15
Message was sent while issue was closed.
On 2014/07/09 15:28:02, bsalomon wrote:
> On 2014/07/09 15:09:08, rmistry wrote:
> > On 2014/07/09 15:07:24, bsalomon wrote:
> > > Can someone give an LGTM? I don't understand why that should be necessary.
> > > 
> > > Ravi, is it because the LGTM on the original patchset came from me?
> > 
> > This is because the original CL was created more than a month ago. More
> details
> > here: https://code.google.com/p/skia/issues/detail?id=2587
> 
> Thanks for the pointer. I get the logic, but is it feasible for it to be based
> on commit date rather than rietveld issue creation data?

According to jrobbins@ there is no way to tell what the commit date is and the
only information we have to work with is the issue creation data. FWIW I was and
am against this feature, it does not make things obvious and behaves magically.

> 
> > 
> > I'll add the missing keywords to this issue, you can then click the CQ
> checkbox.

Powered by Google App Engine
This is Rietveld 408576698