Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: content/browser/service_worker/service_worker_unregister_job.cc

Issue 377153003: Service Worker: set active worker to REDUNDANT when unregistered (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make setting redundant clearly the responsibility of SWStorage Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_unregister_job.cc
diff --git a/content/browser/service_worker/service_worker_unregister_job.cc b/content/browser/service_worker/service_worker_unregister_job.cc
index f60a3b99d3d6cd48880d515b7cde73baf5a77034..7cfad3e1c9b95be06bafc53c6edf6281f1550bdd 100644
--- a/content/browser/service_worker/service_worker_unregister_job.cc
+++ b/content/browser/service_worker/service_worker_unregister_job.cc
@@ -71,11 +71,6 @@ void ServiceWorkerUnregisterJob::DeleteRegistration(
// TODO(nhiroki): When we've implemented the installing version, terminate and
// set it to redundant here as per spec.
- if (registration->waiting_version()) {
- registration->waiting_version()->SetStatus(
- ServiceWorkerVersion::REDUNDANT);
michaeln 2014/07/10 00:55:23 i think we have to Doom the active version if ther
falken 2014/07/10 14:05:12 I thought this would work because when an updated
- }
-
context_->storage()->DeleteRegistration(
registration->id(),
registration->script_url().GetOrigin(),

Powered by Google App Engine
This is Rietveld 408576698