Service Worker: set active worker to REDUNDANT when unregistered

content/browser/service_worker/service_worker_unregister_job.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_unregister_job.h"
 
 #include "content/browser/service_worker/service_worker_context_core.h"
 #include "content/browser/service_worker/service_worker_job_coordinator.h"
 #include "content/browser/service_worker/service_worker_registration.h"
 #include "content/browser/service_worker/service_worker_storage.h"
@@ skipping 53 matching lines @@
 
   DCHECK(registration);
   DeleteRegistration(registration);
 }
 
 void ServiceWorkerUnregisterJob::DeleteRegistration(
     const scoped_refptr<ServiceWorkerRegistration>& registration) {
   // TODO(nhiroki): When we've implemented the installing version, terminate and
   // set it to redundant here as per spec.
 
-  if (registration->waiting_version()) {
-    registration->waiting_version()->SetStatus(
-        ServiceWorkerVersion::REDUNDANT);

[michaeln, 2014/07/10 00:55:23]

i think we have to Doom the active version if there is a waiting version. as
coded, the storage class will Doom at most one version per registration.

[falken, 2014/07/10 14:05:12]

I thought this would work because when an updated version boots out the existing
one (waiting gets stored, active gets deleted), the storage class would wait for
the NoControllees signal from the active and doom it then.

-  }
-
   context_->storage()->DeleteRegistration(
       registration->id(),
       registration->script_url().GetOrigin(),
       base::Bind(&ServiceWorkerUnregisterJob::Complete,
                  weak_factory_.GetWeakPtr()));
 }
 
 void ServiceWorkerUnregisterJob::Complete(ServiceWorkerStatusCode status) {
   CompleteInternal(status);
   context_->job_coordinator()->FinishJob(pattern_, this);
 }
 
 void ServiceWorkerUnregisterJob::CompleteInternal(
     ServiceWorkerStatusCode status) {
   for (std::vector<UnregistrationCallback>::iterator it = callbacks_.begin();
        it != callbacks_.end();
        ++it) {
     it->Run(status);
   }
 }
 
 }  // namespace content