chrome/android/java/res/layout/menu_item.xml - Issue 377083002: Update menu look and feel on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/menu_item.xml

Issue 377083002: Update menu look and feel on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and removed binary pngs Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/four_button_menu_item.xml ('k') | chrome/android/java/res/layout/three_button_menu_item.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/menu_item.xml

diff --git a/chrome/android/java/res/layout/menu_item.xml b/chrome/android/java/res/layout/menu_item.xml

index d917a3a7aea64c748ca8ec367c5e87ced378e981..66bbb8299f4ffc3d7bf7c85efcb2ce8ac6835cbf 100644

--- a/chrome/android/java/res/layout/menu_item.xml

+++ b/chrome/android/java/res/layout/menu_item.xml

@@ -7,26 +7,26 @@

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

android:layout_width="match_parent"

- android:layout_height="wrap_content"

+ android:layout_height="?android:attr/listPreferredItemHeightSmall"

+ android:paddingStart="?android:attr/listPreferredItemPaddingStart"

+ android:paddingEnd="?android:attr/listPreferredItemPaddingEnd"

android:background="?android:attr/listChoiceBackgroundIndicator">

<TextView

android:id="@+id/menu_item_text"

android:textAppearance="?android:attr/textAppearanceLargePopupMenu"

android:layout_weight="1"

android:layout_width="wrap_content"

- android:layout_height="?android:attr/listPreferredItemHeightSmall"

+ android:layout_height="match_parent"

android:layout_gravity="start"

android:gravity="center_vertical"

android:singleLine="true"

- android:paddingStart="9dp"

android:paddingEnd="9dp" />

<view

class="org.chromium.chrome.browser.appmenu.AppMenuItemIcon"

android:id="@+id/menu_item_icon"

android:layout_weight="0"

android:layout_width="wrap_content"

- android:layout_height="?android:attr/listPreferredItemHeightSmall"

+ android:layout_height="match_parent"

android:layout_gravity="end"

- android:gravity="center_vertical"

- android:paddingEnd="8dp" />

+ android:gravity="center_vertical" />

</LinearLayout>